Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated branch name in uses of workflow #7

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

lavanya-sharma-clouddrove
Copy link
Contributor

No description provided.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM Bucket does not have logging enabled 
────────────────────────────────────────────────────────────────────────────────
  main.tf:36-294
────────────────────────────────────────────────────────────────────────────────
   36  ┌ resource "aws_s3_bucket" "this" {
   37count = var.create_bucket ? 1 : 0
   3839bucket        = var.bucket
   40bucket_prefix = var.bucket_prefix
   4142# hack when `null` value can't be used (eg, from terragrunt, https://github.com/gruntwork-io/terragrunt/pull/1367)
   43acl = var.acl != "null" ? var.acl : null
   44..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-s3-enable-bucket-logging
      Impact There is no way to determine the access to this bucket
  Resolution Add a logging block to the resource to enable access logging

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/s3/enable-bucket-logging/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket
────────────────────────────────────────────────────────────────────────────────


Result #2 MEDIUM Bucket does not have versioning enabled 
────────────────────────────────────────────────────────────────────────────────
  main.tf:36-294
────────────────────────────────────────────────────────────────────────────────
   36resource "aws_s3_bucket" "this" {
   37count = var.create_bucket ? 1 : 0
   3839bucket        = var.bucket
   40bucket_prefix = var.bucket_prefix
   4142# hack when `null` value can't be used (eg, from terragrunt, https://github.com/gruntwork-io/terragrunt/pull/1367)
   43acl = var.acl != "null" ? var.acl : null
   44..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-s3-enable-versioning
      Impact Deleted or modified data would not be recoverable
  Resolution Enable versioning to protect against accidental/malicious removal or modification

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/s3/enable-versioning/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket#versioning
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             86.524µs
  parsing              73.064637ms
  adaptation           161.453µs
  checks               3.479719ms
  total                76.792333ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     59
  files read           4

  results
  ──────────────────────────────────────────
  passed               2
  ignored              6
  critical             0
  high                 0
  medium               2
  low                  0

  2 passed, 6 ignored, 2 potential problem(s) detected.

@anmolnagpal anmolnagpal merged commit 49df760 into master Aug 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants