Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fixed hardcoded value by defined in variable file #27

Merged
merged 3 commits into from
Nov 20, 2023
Merged

feat: fixed hardcoded value by defined in variable file #27

merged 3 commits into from
Nov 20, 2023

Conversation

Kasarpooja
Copy link
Contributor

what

  • Remove some hardcoded value from main.tf file and defined it into variable.tf.

@Kasarpooja Kasarpooja requested a review from a team November 17, 2023 14:06
@clouddrove-ci clouddrove-ci self-assigned this Nov 17, 2023
@h1manshu98 h1manshu98 added the WIP Work In Progress label Nov 20, 2023
@Kasarpooja Kasarpooja added Under Review Changes being reviewed by reviewers and removed WIP Work In Progress labels Nov 20, 2023
themaniskshah
themaniskshah approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

omsharma07
omsharma07 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@omsharma07 omsharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omsharma07 omsharma07 merged commit 2c5df5e into master Nov 20, 2023
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/test branch November 20, 2023 16:35
omsharma07 pushed a commit that referenced this pull request Nov 20, 2023
Revert "feat: fixed hardcoded value by defined in variable file (#27)"
5e8e927 
This reverts commit 2c5df5e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omsharma07 omsharma07 omsharma07 approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

@theprashantyadav theprashantyadav Awaiting requested review from theprashantyadav

@mamrajyadav mamrajyadav Awaiting requested review from mamrajyadav

@h1manshu98 h1manshu98 Awaiting requested review from h1manshu98

Assignees

@clouddrove-ci clouddrove-ci

@Kasarpooja Kasarpooja

Labels
Under Review Changes being reviewed by reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Kasarpooja @omsharma07 @themaniskshah @h1manshu98 @clouddrove-ci @anmolnagpal