Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update kubernetes provider name and tag. #64

Merged
merged 5 commits into from
May 7, 2024
Merged

Fix: Update kubernetes provider name and tag. #64

merged 5 commits into from
May 7, 2024

Conversation

nileshgadgi
Copy link
Member

what

  • Update name of data for kubernetes cluster authentication.
  • Add extra tags for kubernetes cluster if required.

why

  • There is no option to only attach particular tag to EKS Cluster only, so added that option.
  • Change dynamic eks cluster name for data blocks with user passed name to simplify Kubernetes authentication.

references

@nileshgadgi nileshgadgi added bug Something isn't working enhancement New feature or request labels May 6, 2024
@nileshgadgi nileshgadgi self-assigned this May 6, 2024
themaniskshah
themaniskshah previously approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nikitadugar
nikitadugar approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@nikitadugar nikitadugar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaibhav7797
vaibhav7797 approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmolnagpal anmolnagpal merged commit 5268f7c into master May 7, 2024
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/k8s-prv branch May 7, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@nikitadugar nikitadugar nikitadugar approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@13archit 13archit 13archit approved these changes

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@d4kverma d4kverma Awaiting requested review from d4kverma

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@nileshgadgi nileshgadgi

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nileshgadgi @anmolnagpal @nikitadugar @themaniskshah @13archit @vaibhav7797