Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: additional tags for public and private subnets #58

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: additional tags for public and private subnets #58

merged 2 commits into from
Sep 13, 2023

Conversation

h1manshu98
Copy link
Member

what

  • Extra subnets tags variable

why

  • updated tags are required when deploying aws-load-balancer-controller helmchart

@clouddrove-ci clouddrove-ci self-assigned this Sep 12, 2023
13archit
13archit approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmolnagpal anmolnagpal merged commit 9b4604d into master Sep 13, 2023
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/extra-subnet-tags branch September 13, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@13archit 13archit 13archit approved these changes

@omsharma07 omsharma07 Awaiting requested review from omsharma07

@mamrajyadav mamrajyadav Awaiting requested review from mamrajyadav

@d4kverma d4kverma Awaiting requested review from d4kverma

Assignees

@h1manshu98 h1manshu98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@h1manshu98 @anmolnagpal @13archit @clouddrove-ci