Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: External-Secrets custom irsa iam-policy #38

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

h1manshu98
Copy link
Member

@h1manshu98 h1manshu98 commented Oct 4, 2023

Why

  • External-Secrets : Release 0.1.0 has issue with irsa_assume_role_policy attribute, it throws error if user does not use it.
  • Istio-Ingress : Updated information about istio-ingress installation in namespace other than istio-system
  • Fix : Removed kubernetes_namespace_v1 resource and dependency from all addons, as this namespace creation is being managed by create_namespace variable.

@h1manshu98 h1manshu98 changed the title Feat: custom irsa iam-policy Feat: External-Secrets custom irsa iam-policy Oct 4, 2023
Copy link
Member

@nileshgadgi nileshgadgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@h1manshu98 h1manshu98 self-assigned this Oct 5, 2023
@h1manshu98 h1manshu98 added bug Something isn't working enhancement New feature or request labels Oct 5, 2023
@anmolnagpal anmolnagpal merged commit b53e931 into master Oct 5, 2023
11 checks passed
@anmolnagpal anmolnagpal deleted the fix/missed-features branch October 5, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants