Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 🚀 Prepared addon for Kube-State-Matrics #29

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Feat: 🚀 Prepared addon for Kube-State-Matrics #29

merged 8 commits into from
Sep 27, 2023

Conversation

nileshgadgi
Copy link
Member

what

  • Feature Kube-State-Metrics addon.
  • Remove unnecessary vars.

why

  • Added kube-state-metrics component to expose cluster-level metrics for monitoring and alerting

references

@nileshgadgi nileshgadgi added the enhancement New feature or request label Sep 26, 2023
@nileshgadgi nileshgadgi self-assigned this Sep 26, 2023
themaniskshah
themaniskshah approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

h1manshu98
h1manshu98 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

vaibhav7797
vaibhav7797 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmolnagpal anmolnagpal merged commit e2a1861 into master Sep 27, 2023
11 checks passed
@anmolnagpal anmolnagpal deleted the feat/kube-state-metrics branch September 27, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@nikitadugar nikitadugar Awaiting requested review from nikitadugar

@d4kverma d4kverma Awaiting requested review from d4kverma

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@nileshgadgi nileshgadgi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nileshgadgi @anmolnagpal @themaniskshah @h1manshu98 @vaibhav7797