Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extra_configs for istio-ingress & custom release-name for all addons. #22

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat: extra_configs for istio-ingress & custom release-name for all addons. #22

merged 3 commits into from
Aug 28, 2023

Conversation

h1manshu98
Copy link
Member

@h1manshu98 h1manshu98 commented Aug 24, 2023 •
edited

  • Added feature to provide extra helm_release attributes in istio-ingress.
  • Added a new Addon FluentBit which by default collects logs from Pods running on EKS cluster and sends them to CloudWatch LogGroup.
  • Removed config directory (which contains override-value.yaml) from basic directory as it not required there.

@h1manshu98 h1manshu98 self-assigned this Aug 24, 2023
@h1manshu98 h1manshu98 added the enhancement New feature or request label Aug 24, 2023
@anmolnagpal anmolnagpal enabled auto-merge (squash) August 24, 2023 19:23
anmolnagpal
anmolnagpal requested changes Aug 28, 2023
View reviewed changes
_examples/complete/config/override-fluent-bit.yaml Outdated Show resolved Hide resolved
_examples/complete/main.tf Outdated Show resolved Hide resolved
VishwajitNagulkar
VishwajitNagulkar approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@VishwajitNagulkar VishwajitNagulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

omsharma07
omsharma07 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@omsharma07 omsharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nikitadugar
nikitadugar approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@nikitadugar nikitadugar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!LGTM

@anmolnagpal anmolnagpal self-requested a review August 28, 2023 15:15
@anmolnagpal anmolnagpal merged commit 769ef7d into master Aug 28, 2023
11 checks passed
@anmolnagpal anmolnagpal deleted the feat/istio-ingress-extra-configs branch August 28, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@omsharma07 omsharma07 omsharma07 approved these changes

@nikitadugar nikitadugar nikitadugar approved these changes

@AshutoshAM2002 AshutoshAM2002 AshutoshAM2002 approved these changes

@VishwajitNagulkar VishwajitNagulkar VishwajitNagulkar approved these changes

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@h1manshu98 h1manshu98

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@h1manshu98 @anmolnagpal @omsharma07 @nikitadugar @AshutoshAM2002 @VishwajitNagulkar