Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: addons output variables and extra_helm_configs, fix: default value file and kiali-istio dependency #21

Merged
merged 3 commits into from
Aug 23, 2023
Merged

feat: addons output variables and extra_helm_configs, fix: default value file and kiali-istio dependency #21

merged 3 commits into from
Aug 23, 2023

Conversation

h1manshu98
Copy link
Member

@h1manshu98 h1manshu98 commented Aug 22, 2023 •
edited

what

  • feat: extra_configs variable to override helm_release attributes
  • feat: added output variables for addons
  • feat: added variable addon_name_iampolicy_json_content to provide custom iam policy for irsa.
  • fix: default value file was being created after every terraform apply
  • fix: added dependency in between kiali and istio-ingress

@h1manshu98
feat: extra_configs variable to override helm_release attributes
1d61304 
fix: default value file was being created after every terraform apply
fix: added dependency in between kiali and istio-ingress
feat: added output variables for addons
@clouddrove-ci clouddrove-ci self-assigned this Aug 22, 2023
@h1manshu98 h1manshu98 self-assigned this Aug 22, 2023
@h1manshu98 h1manshu98 added the enhancement New feature or request label Aug 22, 2023
@anmolnagpal anmolnagpal enabled auto-merge (squash) August 22, 2023 18:10
anmolnagpal
anmolnagpal previously approved these changes Aug 22, 2023
View reviewed changes
@h1manshu98
feat: extra_configs variable to override helm_release attributes
1f1c84e 
feat: added output variables for addons
fix: default value file was being created after every terraform apply
fix: added dependency in between kiali and istio-ingress
fix: tf-lint warnings
@anmolnagpal anmolnagpal self-requested a review August 23, 2023 14:57
@anmolnagpal anmolnagpal merged commit 3b35803 into master Aug 23, 2023
11 checks passed
@anmolnagpal anmolnagpal deleted the feat/extra-helm-configs branch August 23, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@clouddrove-ci clouddrove-ci clouddrove-ci approved these changes

@omsharma07 omsharma07 Awaiting requested review from omsharma07

@nikitadugar nikitadugar Awaiting requested review from nikitadugar

@AshutoshAM2002 AshutoshAM2002 Awaiting requested review from AshutoshAM2002

Assignees

@h1manshu98 h1manshu98

@clouddrove-ci clouddrove-ci

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@h1manshu98 @anmolnagpal @clouddrove-ci