Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add replication configuration and add efs policy #27

Merged
merged 7 commits into from
Sep 5, 2023
Merged

add replication configuration and add efs policy #27

merged 7 commits into from
Sep 5, 2023

Conversation

yadavprakash
Copy link
Contributor

what

  • add replication_configuration
  • add esf policy

why

  • need to update module according new resource

@yadavprakash yadavprakash requested a review from a team August 25, 2023 16:08
@clouddrove-ci clouddrove-ci self-assigned this Aug 25, 2023
@yadavprakash yadavprakash changed the title Feat/issue 242 "add replication configuration and add efs policy Aug 25, 2023
@yadavprakash yadavprakash changed the title "add replication configuration and add efs policy add replication configuration and add efs policy Aug 25, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 5, 2023
View reviewed changes
_example/example.tf Fixed Show fixed Hide fixed
_example/example.tf Fixed Show fixed Hide fixed
_example/example.tf Fixed Show fixed Hide fixed
themaniskshah
themaniskshah approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nikitadugar
nikitadugar approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@nikitadugar nikitadugar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!LGTM

d4kverma
d4kverma approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@d4kverma d4kverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@13archit 13archit merged commit d0ba088 into master Sep 5, 2023
8 checks passed
@13archit 13archit deleted the feat/issue-242 branch September 5, 2023 13:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitadugar nikitadugar nikitadugar approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@d4kverma d4kverma d4kverma approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@13archit 13archit

@d4kverma d4kverma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@yadavprakash @nikitadugar @themaniskshah @d4kverma @anmolnagpal @mamrajyadav @clouddrove-ci @13archit @cloudlovely