Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 🚀 Pull from master branch and create new release. #9

Merged
merged 17 commits into from
Jan 25, 2024

Conversation

nileshgadgi
Copy link
Member

What

  • Pulled from master and removed security group static creation from main.tf root file.
  • Updated example terraform file to with security group creation for DocumentDB Cluster.

Why

  • The best practice is not to create a security group in the root module. create it from an example and pass it as an argument.
  • To give an option for security of documentDB, created example for security group creation.

vaibhav7797
vaibhav7797 previously approved these changes Jan 23, 2024
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 LOW Instance encryption does not use a customer-managed KMS key. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:56-65
────────────────────────────────────────────────────────────────────────────────
   56    resource "aws_docdb_cluster_instance" "this" {
   57      count              = var.enable ? var.cluster_size : 0
   58      identifier         = "${var.database_name}-${count.index + 1}"
   59      cluster_identifier = aws_docdb_cluster.this[0].id
   60      apply_immediately  = var.apply_immediately
   61      instance_class     = var.instance_class
   62      tags               = module.labels.tags
   63      engine             = var.engine
   64      ca_cert_identifier = var.ca_cert_identifier
   65    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-documentdb-encryption-customer-key
      Impact Using AWS managed keys does not allow for fine grained control
  Resolution Enable encryption using customer managed keys

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/documentdb/encryption-customer-key/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/docdb_cluster#kms_key_id
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             68.076µs
  parsing              94.806578ms
  adaptation           125.592µs
  checks               3.281839ms
  total                98.282085ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     40
  files read           4

  results
  ──────────────────────────────────────────
  passed               2
  ignored              1
  critical             0
  high                 0
  medium               0
  low                  1

  2 passed, 1 ignored, 1 potential problem(s) detected.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 LOW Instance encryption does not use a customer-managed KMS key. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:56-65
────────────────────────────────────────────────────────────────────────────────
   56    resource "aws_docdb_cluster_instance" "this" {
   57      count              = var.enable ? var.cluster_size : 0
   58      identifier         = "${var.database_name}-${count.index + 1}"
   59      cluster_identifier = aws_docdb_cluster.this[0].id
   60      apply_immediately  = var.apply_immediately
   61      instance_class     = var.instance_class
   62      tags               = module.labels.tags
   63      engine             = var.engine
   64      ca_cert_identifier = var.ca_cert_identifier
   65    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-documentdb-encryption-customer-key
      Impact Using AWS managed keys does not allow for fine grained control
  Resolution Enable encryption using customer managed keys

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/documentdb/encryption-customer-key/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/docdb_cluster#kms_key_id
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             66.665µs
  parsing              37.098773ms
  adaptation           104.517µs
  checks               8.40007ms
  total                45.670025ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     40
  files read           4

  results
  ──────────────────────────────────────────
  passed               2
  ignored              1
  critical             0
  high                 0
  medium               0
  low                  1

  2 passed, 1 ignored, 1 potential problem(s) detected.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 LOW Instance encryption does not use a customer-managed KMS key. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:56-65
────────────────────────────────────────────────────────────────────────────────
   56    resource "aws_docdb_cluster_instance" "this" {
   57      count              = var.enable ? var.cluster_size : 0
   58      identifier         = "${var.database_name}-${count.index + 1}"
   59      cluster_identifier = aws_docdb_cluster.this[0].id
   60      apply_immediately  = var.apply_immediately
   61      instance_class     = var.instance_class
   62      tags               = module.labels.tags
   63      engine             = var.engine
   64      ca_cert_identifier = var.ca_cert_identifier
   65    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-documentdb-encryption-customer-key
      Impact Using AWS managed keys does not allow for fine grained control
  Resolution Enable encryption using customer managed keys

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/documentdb/encryption-customer-key/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/docdb_cluster#kms_key_id
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             65.893µs
  parsing              64.891433ms
  adaptation           105.166µs
  checks               3.894673ms
  total                68.957165ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     40
  files read           4

  results
  ──────────────────────────────────────────
  passed               2
  ignored              1
  critical             0
  high                 0
  medium               0
  low                  1

  2 passed, 1 ignored, 1 potential problem(s) detected.

Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤟

@clouddrove-ci clouddrove-ci merged commit 8d2c8c1 into master Jan 25, 2024
14 checks passed
@clouddrove-ci clouddrove-ci deleted the feat/release branch January 25, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants