Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update github action and tf code #4

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: update github action and tf code #4

merged 1 commit into from
Oct 20, 2023

Conversation

mamrajyadav
Copy link
Contributor

what

  • add resources.
  • update terraform and aws latest version.
  • update and add github action files.
  • update latest readme.
  • fix tfsec and tflint warnings and removed unnecessary variables.
  • update examples.

@mamrajyadav mamrajyadav requested a review from a team October 17, 2023 14:48
@clouddrove-ci clouddrove-ci self-assigned this Oct 17, 2023
omsharma07
omsharma07 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@omsharma07 omsharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omsharma07 omsharma07 merged commit 9899de5 into master Oct 20, 2023
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-291 branch October 20, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omsharma07 omsharma07 omsharma07 approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@13archit 13archit Awaiting requested review from 13archit

@d4kverma d4kverma Awaiting requested review from d4kverma

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal

Assignees

@mamrajyadav mamrajyadav

@clouddrove-ci clouddrove-ci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mamrajyadav @omsharma07 @themaniskshah @clouddrove-ci