Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: created terarform module for aws github oidc role #47

Merged
merged 5 commits into from
Nov 21, 2023
Merged

feat: created terarform module for aws github oidc role #47

merged 5 commits into from
Nov 21, 2023

Conversation

VishwajitNagulkar
Copy link
Member

  • Terraform Module for aws oidc github role
  • Added feature Allow access to multiple GitHub repositories
  • Added feature to pass multiple permissions to role
  • created readme for usage and deployment steps

@VishwajitNagulkar VishwajitNagulkar requested a review from a team November 21, 2023 17:04
@clouddrove-ci clouddrove-ci self-assigned this Nov 21, 2023
13archit
13archit approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AshutoshAM2002
AshutoshAM2002 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@AshutoshAM2002 AshutoshAM2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

h1manshu98
h1manshu98 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@h1manshu98 h1manshu98 merged commit b72f7b7 into master Nov 21, 2023
19 checks passed
@h1manshu98 h1manshu98 deleted the feat/github-oidc-role branch November 21, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themaniskshah themaniskshah themaniskshah approved these changes

@AshutoshAM2002 AshutoshAM2002 AshutoshAM2002 approved these changes

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@13archit 13archit 13archit approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

@omsharma07 omsharma07 Awaiting requested review from omsharma07

@d4kverma d4kverma Awaiting requested review from d4kverma

Assignees

@clouddrove-ci clouddrove-ci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@VishwajitNagulkar @themaniskshah @AshutoshAM2002 @h1manshu98 @13archit @clouddrove-ci