Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Update branch by pulling from master and dynamic value section. #18

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Feat: Update branch by pulling from master and dynamic value section. #18

merged 6 commits into from
Feb 13, 2024

Conversation

nileshgadgi
Copy link
Member

what

  • Pull latest code from master branch.
  • Update readme workflow to use clouddrove shared workflow.
  • Use dynamic email subject passing for user config.
  • User dynamic email message for user config.
  • Fixed output file to prevent error while enabled var is false.

why

  • This branch was used in i-sec for cognito with static value passed for email message and subject.
  • dynamic email subject and message is the best practice rather than static value pass.

@nileshgadgi nileshgadgi added bug Something isn't working enhancement New feature or request labels Feb 13, 2024
@nileshgadgi nileshgadgi self-assigned this Feb 13, 2024
vaibhav7797
vaibhav7797 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clouddrove-ci clouddrove-ci merged commit 9b05397 into master Feb 13, 2024
12 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue/389 branch February 13, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themaniskshah themaniskshah themaniskshah approved these changes

@clouddrove-ci clouddrove-ci clouddrove-ci approved these changes

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@theprashantyadav theprashantyadav Awaiting requested review from theprashantyadav

@13archit 13archit Awaiting requested review from 13archit

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

Assignees

@nileshgadgi nileshgadgi

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nileshgadgi @themaniskshah @clouddrove-ci @vaibhav7797 @anmolnagpal