Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 🚀 Add example for ECR Cloudwatch dashboard #7

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Feat: 🚀 Add example for ECR Cloudwatch dashboard #7

merged 4 commits into from
Nov 21, 2023

Conversation

nileshgadgi
Copy link
Member

what

  • Added Example for ECR cloudwatch dashboard.
  • Updated README for both examples with versions and source.
  • Fixed gitignore file.
  • Removed unused files from root folder.

why

  • To introduce ECR Dashboard example and use it in the I-sec project.
  • Update readme so that user can easily use the module and SEO purposes.
  • Fixed gitignore for temporary files ignored to be pushed in the git repository.

references

@nileshgadgi nileshgadgi added the enhancement New feature or request label Nov 21, 2023
@nileshgadgi nileshgadgi self-assigned this Nov 21, 2023
themaniskshah
themaniskshah previously approved these changes Nov 21, 2023
View reviewed changes
h1manshu98
h1manshu98 reviewed Nov 21, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
h1manshu98
h1manshu98 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@themaniskshah themaniskshah merged commit d2d09d9 into master Nov 21, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/ecr-dashboard branch November 21, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themaniskshah themaniskshah themaniskshah approved these changes

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal

@omsharma07 omsharma07 Awaiting requested review from omsharma07

@d4kverma d4kverma Awaiting requested review from d4kverma

Assignees

@nileshgadgi nileshgadgi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nileshgadgi @themaniskshah @h1manshu98 @anmolnagpal