Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update new gitignore and readme.yaml #31

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

theprashantyadav
Copy link
Contributor

@theprashantyadav theprashantyadav commented Oct 3, 2023

what

  • update .gitignore and readme.yaml

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting jira issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a Jira issue #123

@theprashantyadav theprashantyadav requested a review from a team October 3, 2023 08:38
@clouddrove-ci clouddrove-ci self-assigned this Oct 3, 2023
@theprashantyadav theprashantyadav changed the title feat: update new gitignore and readme.yaml Feat: update new gitignore and readme.yaml Oct 3, 2023
@theprashantyadav theprashantyadav changed the title Feat: update new gitignore and readme.yaml Fix: update new gitignore and readme.yaml Oct 3, 2023
@theprashantyadav theprashantyadav self-assigned this Oct 3, 2023
@theprashantyadav theprashantyadav added the bug Something isn't working label Oct 3, 2023
Copy link
Contributor

@omsharma07 omsharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omsharma07 omsharma07 merged commit 12f0fce into master Oct 3, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issue-563 branch October 3, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants