Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clouddrove/github-shared-workflows from 1.2.2 to 1.2.4 #31

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 8, 2024

Bumps clouddrove/github-shared-workflows from 1.2.2 to 1.2.4.

Release notes

Sourced from clouddrove/github-shared-workflows's releases.

1.2.4

📝 Documentation Changes

1.2.3

🐛 Bug Fixes

📝 Documentation Changes

Changelog

Sourced from clouddrove/github-shared-workflows's changelog.

[1.2.4] - 2024-04-08

📝 Documentation Changes

[1.2.3] - 2024-04-08

🐛 Bug Fixes

📝 Documentation Changes

Commits
  • 41ddd1b Feat/update exampl name (#130)
  • 096ac8b docs: update CHANGELOG.md for 1.2.3
  • ae37686 fix: terraform destroy data-type and helm --set flag to pass secrets and mult...
  • c138c5a Feat/actions (#127)
  • bd27f8d docs: update CHANGELOG.md for 1.2.2
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [clouddrove/github-shared-workflows](https://github.com/clouddrove/github-shared-workflows) from 1.2.2 to 1.2.4.
- [Release notes](https://github.com/clouddrove/github-shared-workflows/releases)
- [Changelog](https://github.com/clouddrove/github-shared-workflows/blob/master/CHANGELOG.md)
- [Commits](clouddrove/github-shared-workflows@1.2.2...1.2.4)

---
updated-dependencies:
- dependency-name: clouddrove/github-shared-workflows
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from anmolnagpal as a code owner April 8, 2024 14:47
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 8, 2024
@dependabot dependabot bot requested a review from clouddrove-ci as a code owner April 8, 2024 14:47
@dependabot dependabot bot added the github_actions Pull requests that update GitHub Actions code label Apr 8, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 8, 2024

Dependabot tried to add @approvers as a reviewer to this PR, but received the following error from GitHub:

POST https://github.com/gitapi/repos/clouddrove/terraform-aws-cloudtrail-baseline/pulls/31/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the clouddrove/terraform-aws-cloudtrail-baseline repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

@anmolnagpal
Copy link
Contributor

Terraform Security Scan Failed

Show Output
Result #1 LOW Log group is not encrypted. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:71-76
────────────────────────────────────────────────────────────────────────────────
   71    resource "aws_cloudwatch_log_group" "cloudtrail_events" {
   72      count             = var.enabled ? 1 : 0
   73      name              = var.cloudwatch_logs_group_name
   74      retention_in_days = var.cloudwatch_logs_retention_in_days
   75      tags              = module.labels.tags
   76    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-cloudwatch-log-group-customer-key
      Impact Log data may be leaked if the logs are compromised. No auditing of who have viewed the logs.
  Resolution Enable CMK encryption of CloudWatch Log Groups

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/cloudwatch/log-group-customer-key/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_group#kms_key_id
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             122.509µs
  parsing              63.955919ms
  adaptation           145.693µs
  checks               6.206209ms
  total                70.43033ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     53
  files read           4

  results
  ──────────────────────────────────────────
  passed               0
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  1

  1 potential problem(s) detected.

@anmolnagpal anmolnagpal merged commit 41f6d5c into master Apr 8, 2024
20 checks passed
@anmolnagpal anmolnagpal deleted the dependabot/github_actions/clouddrove/github-shared-workflows-1.2.4 branch April 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants