Feat: Feature AWS Athena Terraform module 🚀 #1
Conversation
nileshgadgi
requested review from
nikitadugar,
themaniskshah,
yadavprakash and
d4kverma
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
| module "athena" { | ||
| source = "../../" | ||
| name = "athena" | ||
| environment = "test" | ||
| label_order = ["name", "environment"] | ||
| enabled = true | ||
| workgroup_force_destroy = true | ||
|
|
||
| # S3 Bucket Configuration | ||
| bucket_force_destroy = true | ||
| s3_output_path = "accessLogs/queryresults/" # The S3 bucket path used to store query results | ||
| bucket_versioning = true | ||
|
|
||
| # Database for Athena | ||
| databases = { | ||
| database1 = { | ||
| force_destroy = true | ||
| properties = { | ||
| custom_prop_1 = "example" | ||
| } | ||
| encryption_configuration = { | ||
| encryption_option = "SSE_KMS" | ||
| } | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / defsec
S3 Bucket does not have logging enabled. Warning
There was a problem hiding this comment.
Bucket Logging in the Athena's s3 bucket is not required because we are not using s3 for logging.
| module "athena" { | ||
| source = "../../" | ||
| name = "athena" | ||
| environment = "test" | ||
| label_order = ["name", "environment"] | ||
| enabled = true | ||
| workgroup_force_destroy = true | ||
|
|
||
| # S3 Bucket Configuration | ||
| bucket_force_destroy = true | ||
| s3_output_path = "accessLogs/queryresults/" # The S3 bucket path used to store query results | ||
| bucket_versioning = true | ||
|
|
||
| # Database for Athena | ||
| databases = { | ||
| database1 = { | ||
| force_destroy = true | ||
| properties = { | ||
| custom_prop_1 = "example" | ||
| } | ||
| encryption_configuration = { | ||
| encryption_option = "SSE_KMS" | ||
| } | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / defsec
S3 Data should be versioned Warning
There was a problem hiding this comment.
Data version will have additional cost in s3 so didn't used it in example.
| module "s3_bucket" { | ||
| source = "clouddrove/s3/aws" | ||
| version = "1.3.0" | ||
| name = format("%s-bucket-test", local.name) | ||
| versioning = true | ||
| acl = "private" | ||
| force_destroy = true | ||
| } |
Check warning
Code scanning / defsec
S3 Bucket does not have logging enabled. Warning
There was a problem hiding this comment.
Data version in the Athena's s3 bucket is not required because we are not using s3 for logging.
| module "s3_bucket" { | ||
| source = "clouddrove/s3/aws" | ||
| version = "1.3.0" | ||
| name = format("%s-bucket-test", local.name) | ||
| versioning = true | ||
| acl = "private" | ||
| force_destroy = true | ||
| } |
Check warning
Code scanning / defsec
S3 Data should be versioned Warning
There was a problem hiding this comment.
Data version in the Athena's s3 bucket is not required because we are not using s3 for logging.
nileshgadgi
changed the title
what
why
references