Skip to content

Commit

Permalink
feat: code dynamic and add resource, variable description
Browse files Browse the repository at this point in the history
  • Loading branch information
theprashantyadav committed Jul 13, 2023
1 parent e453dc5 commit da05e2c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
10 changes: 3 additions & 7 deletions _examples/complete/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ module "acm" {
label_order = ["name", "environment"]

enable_aws_certificate = true
domain_name = "example.cam"
subject_alternative_names = ["*.example.cam"]
domain_name = "clouddrove.ca"
subject_alternative_names = ["*.clouddrove.ca"]
validation_method = "DNS"
enable_dns_validation = false
}
Expand Down Expand Up @@ -76,7 +76,7 @@ module "api_gateway" {
environment = "test"
label_order = ["environment", "name"]

domain_name = "example.cam"
domain_name = "clouddrove.ca"
domain_name_certificate_arn = module.acm.arn
integration_uri = module.lambda.arn
zone_id = "1234059QJ345674343"
Expand All @@ -103,8 +103,4 @@ module "api_gateway" {
authorizer_key = "cognito"
}
}
access_log_settings = {
default_stage_access_log_destination_arn = "*"
default_stage_access_log_format = " HTTP"
}
}

Check warning

Code scanning / defsec

API Gateway stages for V1 and V2 should have access logging enabled Warning

Access logging is not configured.
6 changes: 3 additions & 3 deletions _examples/vpc_link_api/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ module "acm" {
label_order = ["name", "environment"]

enable_aws_certificate = true
domain_name = "example.cam"
subject_alternative_names = ["*.example.cam"]
domain_name = "clouddrove.ca"
subject_alternative_names = ["*.clouddrove.ca"]
validation_method = "DNS"
enable_dns_validation = false
}
Expand Down Expand Up @@ -126,7 +126,7 @@ module "api_gateway" {
environment = "test"
label_order = ["environment", "name"]

domain_name = "example.cam"
domain_name = "clouddrove.ca"
create_vpc_link_enabled = true
zone_id = "1`23456059QJZ25345678"
integration_uri = module.lambda.arn
Expand Down

0 comments on commit da05e2c

Please sign in to comment.