Add infraType field to TbSpecInfo/TbImageInfo and assets #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sykim-etri 오오!! 감사합니다. 검토해보겠습니다. |
seokho-son
reviewed
Jul 11, 2024
There was a problem hiding this comment.
@sykim-etri 감사합니다! 사소한 코멘트가 있습니다.
그리고, 유닛테스트 일부 개선해주셨는데, 기존에 있던 한글 문구는 모두 영어로 수정 부탁드릴게요.
| @@ -2032,6 +2047,23 @@ func UpdateResourceObject(nsId string, resourceType string, resourceObject inter | |||
|
|
|||
| } | |||
|
|
|||
| func expandInfraType(infraType string) string { | |||
| expInfraTypeList := []string{} | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| infraType := strings.ToLower(infraType) | |
혹시 모르니, 소문자 기준 비교를 하면 좋을 것 같습니다. _
sykim-etri
force-pushed
the
add-infratype-field-to-tbspecinfo-and-tbimageinfo
branch
from
4acc77b
to
3fc98d0
Compare
ref cloud-barista#1665 - Update alibaba ubuntu 22.04 image info - Update NHNCloud ubuntu 20.04 and ubuntu 22.04 image info for vm/k8s - Update TbImageInfo with description from assets - Remove nodeImage in k8sclusterinfo.yaml - Comment out deprecated DB access and test filterSpecsByRange() with InfraType
sykim-etri
force-pushed
the
add-infratype-field-to-tbspecinfo-and-tbimageinfo
branch
from
3fc98d0
to
48f66c4
Compare
|
@sykim-etri 업데이트 완료하신 경우에는 댓글로 알려주세요~ :) |
본 PR 범위 내에서는 업데이트 완료했습니다. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TbSpecInfo와 TbImageInfo, assets/cloudspec.csv와 assets/cloudimage.csv에 InfraType 항목을 추가하고(#1665), csv 파일 내용을 일부 업데이트합니다.
활용
기타