Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if type assertion is OK or not to avoid panic #1638

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Check if type assertion is OK or not to avoid panic #1638

merged 1 commit into from
Jun 24, 2024

Conversation

yunkon-kim
Copy link
Member

  • Check if type assertion is OK or not in
    • func ExecuteHttpRequest()
    • func ResponseBodyDump(), middleware

@yunkon-kim
Check if type assertion is OK or not to avoid panic
23221bf 
* Check if type assertion is OK or not in
  - func ExecuteHttpRequest()
  - func ResponseBodyDump(), middleware
seokho-son
seokho-son approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son merged commit d362c9a into cloud-barista:main Jun 24, 2024
4 checks passed
@yunkon-kim yunkon-kim deleted the 240617-20 branch July 30, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunkon-kim @seokho-son