Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conf.env and testSet.env for Domestic CSPs, and Add modify_nginx.sh to Set nginx server on NCP Classic VM #1604

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

innodreamer
Copy link
Member

@innodreamer innodreamer commented Jun 4, 2024

  • Update conf.env and testSet.env to test Domestic CSPs
    • Update VMImage and VMSpec info of each region in Domestic CSPs
      • Note : The NCP Classic Singapore region is available normally without any problems with 'Standard' and 'Compact' VMSpec
    • Apply modified connection config names according to the recent CB-TB updates
  • Add modify_nginx.sh to Set nginx server on NCP Classic VM
    • Note :
      • In the case of NCP Classic, IPv6 was disabled by default in VM, so an error occurs when nginx is installed and started.
      • Therefore, this script must be executed first before installing nginx.

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@innodreamer 기여 감사합니다.

  • modify_nginx.sh 의 추가 필요성과
  • 업데이트된 국내 CSP 테스트 정보를 기준으로 구동 테스트가 완료된 것인지 질문 드립니다.

exit 1
fi

# Use sed to comment out the specified line if it is not already commented
Copy link
Member

@seokho-son seokho-son Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify_nginx.sh 해당 스크립트는 꼭 필요한 스크립트 인지요?
Nginx 및 설정 변경이 필요하다면,
https://github.com/cloud-barista/cb-tumblebug/tree/main/scripts/usecases
에 nginx 항목을 만들어서 추가해주셔도 좋을 것 같습니다.

일시적 테스트 용도로 추가해주신 것이라면, 의도에 맞는 file 명으로 수정해두고, 향후에 정리해야할 것 같습니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seokho-son NCP Classic의 경우, VM에서 ipv6 설정이 disable 된 상태이므로 Nginx 설치 후 구동시 에러가 발생합니다.
따라서 modify_nginx.sh를 먼저 실행하고 nigix 설치/구동이 필요합니다.
일단 modify_nginx.sh 파일은 삭제 시키고 향후 필요시 usecase 디렉토리에 별도 항목으로 추가하도록 하겠습니다.

@seokho-son seokho-son added the wip working in progress (do not merge) label Jun 5, 2024
@seokho-son
Copy link
Member

@innodreamer
국내 CSP 테스트 관련 추가 스크립트는 대부분 중복 스크립트로, 향후 모두 삭제 및 기존 일반화된 스크립트에 병합된다는 전제하에, 승인하겠습니다. 고생 많으셨습니다.

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seokho-son seokho-son merged commit 6c9db65 into cloud-barista:main Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip working in progress (do not merge)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants