Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean CSP supports (MCIS dynamic hold option and preserve regionname case) #1567

Merged
merged 1 commit into from
May 15, 2024

Conversation

seokho-son
Copy link
Member

Preserve region name case

Provisioning MCIS dynamic with hold option

image

  • with "hold" option, MCIS dynamic will be holed after it creates requires resources.

image

  • holded MCIS can be continued with control MCIS option continue (or withdraw for writhdraw)

@seokho-son
Copy link
Member Author

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label May 15, 2024
@cb-github-robot cb-github-robot merged commit 9b1d50d into cloud-barista:main May 15, 2024
4 checks passed
@seokho-son
Copy link
Member Author

PTAL: @innodreamer

@dev4unet
Copy link
Member

dev4unet commented May 29, 2024

@seokho-son 국내 및 해외의 멀티 CSP가 한번에 선택되는 경우를 고려하고 이슈가 없는 AWS 등의 CSP는 Hold하지 않아도 되겠지만 혹시라도 특정 목적(기획?)에 의해서 이슈가 없는 AWS 등의 CSP도 Hold가 필요한 경우에 Hold 할 수 있도록 고려해서 Hold 시에는 기본은 All로 모두 Hold하고, 만약 희망하는 경우 특정 CSP의 경우는 Hold 하지 않고 기존대로 처리될 수 있도록 활용도를 감안해서 Hold 되는 범위나 대상 등의 Hold에 대한 범위 또는 타겟 등의 세부 옵션을 지정할 수 있는 방식이 지원되면 좋을 것 같습니다.

@seokho-son
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved and will be merged soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NCP,KT,NHN] use strings.EqualFold to check strings (region, zone, csp name)
3 participants