Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows for CI and CD #1548

Merged
merged 1 commit into from
May 7, 2024
Merged

Update workflows for CI and CD #1548

merged 1 commit into from
May 7, 2024

Conversation

yunkon-kim
Copy link
Member

This PR will update the workflows for CI and CD (previously, publish-multi-arch-container-images.yaml and build-amd64-container-image.yaml).

  • To make it clear where errors occur, building source code and container image are separated.
  • Container images will be published
    • with semver and latest tags for the stable version. (latest will point to the latest semver tag.)
    • with edge for the unstable version. (When a PR is merged, a container image is created (overwritten) with the edge tag, which may not be stable.)

It has the advantage of

  • utilizing stable images with the semver and latest tag, and
  • testing the recent developments with the edge tag.

@yunkon-kim
Update workflows for CI and CD
623319c 
* CI
  - Build source code
  - Build container image

* CD
  - On tagged, publish container image with `semver` and `latest` tags (stable)
  - On merged, publish container image with `edge` tag (unstable)
@seokho-son
Copy link
Member

Thanks, @yunkon-kim!

I have a minor question regarding the naming of our workflows:
.github/workflows/continuous-delivery.yaml
.github/workflows/continuous-integration.yaml

How about changing the names to something more intuitive? For instance, simply build-test and publish-container-image? This might help avoid confusion given that people may have different understandings of CI/CD terms.

@yunkon-kim
Copy link
Member Author

@seokho-son First of all, I have no objection to naming ^^

I don't think the term CI/CD will be understood much differently. Considering that related features will be added later, I think it would be good to leave it as is.

However, if related features are not added, I think CI should be changed to build test. It seems okay to use either term because publish container image and continuous-delivery can be understood to have almost the same meaning.

@seokho-son
Copy link
Member

/approve

@seokho-son
Copy link
Member

Agreed ! :)

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label May 7, 2024
@seokho-son seokho-son merged commit 585e2dd into cloud-barista:main May 7, 2024
4 checks passed
@yunkon-kim yunkon-kim deleted the 240507-14 branch June 10, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions approved these changes

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

Assignees
No one assigned
Labels
approved This PR is approved and will be merged soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunkon-kim @seokho-son