JVMTI followup #3700
Merged
JVMTI followup #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexander-yakushev
commented
Jun 3, 2024
•
alexander-yakushev
commented
- Per @yuhan0 suggestion, I've changed the way how allowAttachSelf property is injected for tools.deps. It looks marginally cleaner this way.
- Updated the docs clarifying that allowAttachSelf can (and should) be specified manually when the REPL is not started through jack-in.
bbatsov
reviewed
Jun 3, 2024
| IMPORTANT: `cider-enable-nrepl-jvmti-agent` has no effect if you start a REPL | ||
| process outside of Emacs and connect to it with `cider-connect`. In that | ||
| scenario, you have to add `-Djdk.attach.allowAttachSelf` Java property manually | ||
| through the means of the build tool. |
There was a problem hiding this comment.
Maybe you can also add here some snippets for lein and the Clojure CLI, so it'd be a tiny bit easier for the majority of the users to figure out what they have to do.
alexander-yakushev
force-pushed
the
jvmti-followup
branch
2 times, most recently
from
3c11193
to
9e73100
Compare
alexander-yakushev
force-pushed
the
jvmti-followup
branch
from
9e73100
to
d9125d5
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.