-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address most Emacs 29 warnings #3617
Open
vemv
wants to merge
1
commit into
master
Choose a base branch
from
3606--emacs29
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,8 +64,8 @@ | |
|
||
(defcustom cider-show-error-buffer t | ||
"Control the popup behavior of cider stacktraces. | ||
The following values are possible t or 'always, 'except-in-repl, | ||
'only-in-repl. Any other value, including nil, will cause the stacktrace | ||
The following values are possible t or \='always, \='except-in-repl, | ||
\='only-in-repl. Any other value, including nil, will cause the stacktrace | ||
not to be automatically shown. | ||
|
||
Irrespective of the value of this variable, the `cider-error-buffer' is | ||
|
@@ -88,7 +88,7 @@ in order to void its effect." | |
(defcustom cider-auto-jump-to-error t | ||
"Control the cursor jump behavior in compilation error buffer. | ||
When non-nil automatically jump to error location during interactive | ||
compilation. When set to 'errors-only, don't jump to warnings. | ||
compilation. When set to \='errors-only, don\='t jump to warnings. | ||
When set to nil, don't jump at all." | ||
:type '(choice (const :tag "always" t) | ||
(const errors-only) | ||
|
@@ -120,7 +120,7 @@ Only applies when the *cider-inspect* buffer is currently visible." | |
(defcustom cider-save-file-on-load 'prompt | ||
"Controls whether to prompt to save the file when loading a buffer. | ||
If nil, files are not saved. | ||
If 'prompt, the user is prompted to save the file if it's been modified. | ||
If \='prompt, the user is prompted to save the file if it\='s been modified. | ||
If t, save the file without confirmation." | ||
:type '(choice (const prompt :tag "Prompt to save the file if it's been modified") | ||
(const nil :tag "Don't save the file") | ||
|
@@ -405,13 +405,12 @@ Returns the position at which PROPERTY was found, or nil if not found." | |
_ARG and _RESET are ignored, as there is only ever one compilation error. | ||
They exist for compatibility with `next-error'." | ||
(interactive) | ||
(cl-labels ((goto-next-note-boundary | ||
() | ||
(let ((p (or (cider-find-property 'cider-note-p) | ||
(cider-find-property 'cider-note-p t)))) | ||
(when p | ||
(goto-char p) | ||
(message "%s" (get-char-property p 'cider-note)))))) | ||
(cl-labels ((goto-next-note-boundary () | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Weirdly this doesn't look like the indentation in the Emacs 29 changelog. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am using 29.2 and can confirm that the indentation is not correct here. |
||
(let ((p (or (cider-find-property 'cider-note-p) | ||
(cider-find-property 'cider-note-p t)))) | ||
(when p | ||
(goto-char p) | ||
(message "%s" (get-char-property p 'cider-note)))))) | ||
;; if we're already on a compilation error, first jump to the end of | ||
;; it, so that we find the next error. | ||
(when (get-char-property (point) 'cider-note-p) | ||
|
@@ -538,11 +537,10 @@ into a new error buffer." | |
;; Causes are returned as a series of messages, which we aggregate in `causes' | ||
(let (causes ex-phase) | ||
(cider-nrepl-send-request | ||
(thread-last | ||
(map-merge 'list | ||
'(("op" "analyze-last-stacktrace")) | ||
(cider--nrepl-print-request-map fill-column)) | ||
(seq-mapcat #'identity)) | ||
(thread-last (map-merge 'list | ||
'(("op" "analyze-last-stacktrace")) | ||
(cider--nrepl-print-request-map fill-column)) | ||
(seq-mapcat #'identity)) | ||
(lambda (response) | ||
(nrepl-dbind-response response (phase) | ||
(when phase | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should pull the params on the same line as the function name.