Skip to content

Commit

Permalink
Don't void nrepl-err-handler
Browse files Browse the repository at this point in the history
This was an extra measure included as part of #3607

It resulted in `*cider-error*` not being shown, in certain scenarios.

That particular measure wasn't critical in avoiding the issue tackled in that PR.
  • Loading branch information
vemv committed Jan 21, 2024
1 parent f7f8e2c commit b7b366b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions cider-eval.el
Original file line number Diff line number Diff line change
Expand Up @@ -849,8 +849,7 @@ REPL buffer. This is controlled via
(when-let ((conn (with-current-buffer buffer
(cider-current-repl))))
(when (cider-nrepl-op-supported-p "analyze-last-stacktrace" conn)
(let ((nrepl-err-handler (lambda (&rest _))) ;; ignore any errors during this request to avoid any recursion
(nrepl-sync-request-timeout 4)) ;; ensure that this feature cannot possibly create an overly laggy UX
(let ((nrepl-sync-request-timeout 4)) ;; ensure that this feature cannot possibly create an overly laggy UX
(when-let* ((result (nrepl-send-sync-request (thread-last (map-merge 'list
'(("op" "analyze-last-stacktrace"))
(cider--nrepl-print-request-map fill-column))
Expand Down

0 comments on commit b7b366b

Please sign in to comment.