support changable collection #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this, just merged back into master and released it with |
DimitarNestorov
pushed a commit
to codemotionapps/react-sortable-hoc
that referenced
this pull request
Feb 4, 2019
Support changing an item's collection prop on the fly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my collection name changes ( I keep the path to the parent in the collection name, eg 'grandparent:0:parent:5:children' ) and the parents themselves are sortable, as such their indexes can change.
I didn't want to bind a new closure for each
onSortEndbecause I have so many items.Anyhow, one PR