Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to pointer-events: none on Sortable helper #160

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

clauderic
Copy link
Owner

@@ -288,6 +288,7 @@ export default function sortableContainer(WrappedComponent, config = {withRef: f
this.helper.style.width = `${this.width}px`;
this.helper.style.height = `${this.height}px`;
this.helper.style.boxSizing = 'border-box';
this.helper.style.pointerEvents = 'none';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

White space police! 🚓 Tab spotted!👮

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

The one time I'm lazy and decide to use the built-in github editor 🙄

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never will I ever again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOTCHA! 🥇

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier-bot would not have allowed this 🤖

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(╯°□°)╯︵ ┻━┻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be time to step away from open source, Clauderic

@clauderic clauderic force-pushed the feature/helper_pointer_events branch from fbb7c5b to e0c7f79 Compare March 11, 2017 01:57
@clauderic clauderic merged commit 6ca8674 into master Mar 11, 2017
@clauderic clauderic deleted the feature/helper_pointer_events branch March 11, 2017 02:00
DimitarNestorov pushed a commit to codemotionapps/react-sortable-hoc that referenced this pull request Feb 4, 2019
…r_events

Default to `pointer-events: none` on Sortable helper
@ahmedisam99
Copy link

Why!! just why??!!?
don't you think you should use a property to allow users to specify whether to disable pointer events or not? @clauderic
It's causing a trouble with all users wanting to specify a custom cursor while dragging the list-item.

@josias-r
Copy link

josias-r commented Feb 4, 2022

@clauderic Took me a while until I finally found why the cursor is not behaving as it is in the examples. Ahmedisam99 pointed it out already, in a rude manner though, that this change breaks the cursor styles. Would be nice if this was configurable. Also it's misleading that the Examples are not up-to-date where this change has not yet been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants