Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with Kamaji extension #9

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Jul 4, 2024

This PR fixes some issues I've detected while doing tests with Rancher Extensions for the upcoming Rancher 2.9 release:

  • a routing issue (hard refresh on product route wouldn’t work - fixes to product.ts and routes.ts)
  • layout issue (sidebar disappears - removal of layout: "single" in Dashboard component)
  • product name needs to be a single word like kamaji not multitenancy management
  • updated shell package dependency to latest stable version
  • fixes some linting issues
  • version bumping to prepare for a release

To test:

Before
before

After
after

package.json Outdated Show resolved Hide resolved
pkg/kamaji/types.ts Show resolved Hide resolved
@aalves08
Copy link
Contributor Author

@bsctl are there any extra changes besides bumping the version to 0.2.0 that you would like me to do?

@bsctl
Copy link
Member

bsctl commented Jul 17, 2024

@aalves08

@bsctl are there any extra changes besides bumping the version to 0.2.0 that you would like me to do?

It should be fine, please bump to 0.2.0

@aalves08
Copy link
Contributor Author

@bsctl @prometherion change done. Requesting final approval 🙏

Copy link
Member

@bsctl bsctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bsctl bsctl merged commit 2cc09ea into clastix:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants