Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validator take &str instead of String #1884

Merged
merged 1 commit into from
May 1, 2020
Merged

Make validator take &str instead of String #1884

merged 1 commit into from
May 1, 2020

Conversation

CreepySkeleton
Copy link
Contributor

Closes #1165

pksunkara
pksunkara requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

src/build/app/mod.rs Outdated Show resolved Hide resolved
tests/validators.rs Show resolved Hide resolved
@kbknapp
Copy link
Member

kbknapp commented Apr 30, 2020 

$ cargo test --doc
 [..]
test result: FAILED. 115 passed; 182 failed; 2 ignored; 0 measured; 0 filtered out

Look like all of which are both validator and validator_os set. So something funky there.

@CreepySkeleton
Copy link
Contributor Author

Wrong condition in the assert...

@kbknapp funky? Doesn't add up with context 😃

@CreepySkeleton CreepySkeleton force-pushed the validator_ref branch 2 times, most recently from c7b038b to b10954c Compare April 30, 2020 18:48
@pksunkara
Copy link
Member

Benches needs to be fixed. And what happened to the azure tests?

@CreepySkeleton
Copy link
Contributor Author

Probably there was some error on their side, now azure is back

pksunkara
pksunkara approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented May 1, 2020

Build succeeded:

@bors bors bot merged commit 70287ea into master May 1, 2020
@bors bors bot deleted the validator_ref branch May 1, 2020 12:10
@camsteffen camsteffen mentioned this pull request Feb 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara approved these changes

@kbknapp kbknapp kbknapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validator_os takes &OsStr, but validator takes String
3 participants
@CreepySkeleton @kbknapp @pksunkara