Allow debug logs to work with clap tests themselves

[pksunkara]

No description provided.

[pksunkara]

Oops. Looks like specifying deps based on some cfg won't work

The same applies to cfg(debug_assertions), cfg(test) and cfg(proc_macro). These values will not work as expected and will always have the default value returned by rustc --print=cfg. There is currently no way to add dependencies based on these configuration values.

So, they will always be included. But they won't actually be used anywhere when debug_assertions is set false.

Related to rust-lang/cargo#5777

[CreepySkeleton]

To be honest, I am a bit unhappy with this PR. More specifically:

• clap is a library, not the binary. Libraries are not supposed to initialize the logger:

  From log crate' doc:

  Libraries should link only to the log crate, and use the provided macros to log whatever information will be useful to downstream consumers.

  We may use it as internal-only hack, but we would need to put it behind a cfg (and test with RUSTFLAGS='--cfg clap_debug' cargo run ...).

• Output format: please don't strip struct' name from output. It really helps me to debug things, and module name is not always enough. Also, can we insert a tab between [...] and the message so the message appears aligned? Logs can be lengthy and it's not particularly easy to scan though it when it's unaligned.

[CreepySkeleton]

Great! Just a small nitpick

[CreepySkeleton]

bors r+

[bors]

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

[pksunkara]

bors r=CreepySkeleton

[bors]

Build succeeded:

• CI
• clap-rs.clap
• continuous-integration/travis-ci/push