Delete old clangd installation after installing a new one #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-mccall
commented
Jan 25, 2022
| @@ -29,6 +29,10 @@ class UI { | |||
| coc.window.showMessage(`Reusing existing ${release} installation in ${this.storagePath}`); | |||
| return true; | |||
| } | |||
| async promptDelete(path: string) : Promise<boolean|undefined> { | |||
| coc.window.showMessage(`Deleting previous clangd installation in ${path}`); | |||
There was a problem hiding this comment.
I'm unsure what the best behavior is here: for vscode we'll prompt and let the user choose delete/keep/dismiss: https://github.com/clangd/vscode-clangd/pull/288/files#diff-66f6667b405ea9ee158525b6f12729e879388bcc95af6a683118aceb012685b0
coc-clangd mostly does the preferred option silently so far.
I'd be happy with delete+log, keep+log, or coc.window.showPrompt(). Modal dialogs are annoying, though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY FOR MERGE: depends on clangd/node-clangd#12