Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made ckeditor5-dev-tests a general use application #594

Closed
wants to merge 4 commits into from
Closed

Conversation

fredck
Copy link
Contributor

@fredck fredck commented Feb 7, 2020

Suggested merge commit message (convention)

Feature: Made ckeditor5-dev-tests a general use application. Closes ckeditor/ckeditor5#7196.


Additional information

This implementation is pretty simple, doing mainly the following:

  • Allow --files to point to resolved globs, by beginning the with ./.
  • Introduced --coverage-paths to point to additional paths to be included in coverage.

It basically doesn't change the current features, just adding to top of them.

I've been able to successfully use this with arguments like --files=./tests/unit/**/*.js --coverage-paths=./src.

This should even allow to enable tests when cloning a single editor plugin, instead of having to deal with the big and fancy ckeditor5 repo.

@coveralls
Copy link

coveralls commented Feb 23, 2020

Coverage Status

Coverage increased (+0.03%) to 87.174% when pulling 1ad3ab9 on t/593 into fb13c95 on master.

@pomek
Copy link
Member

pomek commented Oct 11, 2021

See: ckeditor/ckeditor5#7196 (comment).

@fredck
Copy link
Contributor Author

fredck commented Mar 29, 2023

Outdated

@fredck fredck closed this Mar 29, 2023
@pomek pomek deleted the t/593 branch November 28, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants