Add Support for Joomla5 builds #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(edited) civicrm/civicrm-core#31325 changes the name of the zip to 'civicrm-$version-joomla5bc.zip' to emphasize the dependence on the Back Compatibility plugin, and to clear the way for using '...-joomla5.zip' as the version without that dependency. |
aydun
reviewed
Oct 21, 2024
| @@ -180,6 +180,8 @@ protected function getLatestStable() { | |||
| self::STABLE_DOWNLOAD_URL, $rev, $rev), | |||
| 'Joomla' => sprintf('%s/%s/civicrm-%s-joomla.zip', | |||
| self::STABLE_DOWNLOAD_URL, $rev, $rev), | |||
| 'Joomla5' => sprintf('%s/%s/civicrm-%s-joomla5.zip', | |||
There was a problem hiding this comment.
With the changes in civicrm/civicrm-core#31325 this become ... '-joomla5bc.zip'
aydun
reviewed
Oct 21, 2024
| @@ -146,7 +146,7 @@ public function createRevDocs() { | |||
| * Ex: 'Drupal' or 'Drupal6'. | |||
| */ | |||
| protected function getTarName($file) { | |||
| if (!preg_match(';^civicrm-(.*)-(backdrop|drupal|drupal6|joomla|joomla-alt|standalone|starterkit|wordpress|wporg|l10n)(-[0-9]+)?\.(zip|tar.gz|tgz)$;i', $file['basename'], $matches)) { | |||
| if (!preg_match(';^civicrm-(.*)-(backdrop|drupal|drupal6|joomla|joomla5|joomla-alt|standalone|starterkit|wordpress|wporg|l10n)(-[0-9]+)?\.(zip|tar.gz|tgz)$;i', $file['basename'], $matches)) { | |||
aydun
reviewed
Oct 21, 2024
| @@ -155,6 +155,7 @@ protected function getTarName($file) { | |||
| 'drupal' => 'Drupal', | |||
| 'drupal6' => 'Drupal6', | |||
| 'joomla' => 'Joomla', | |||
| 'joomla5' => 'Joomla5', | |||
aydun
reviewed
Oct 21, 2024
| @@ -44,6 +44,7 @@ public function getDownloadExamples() { | |||
| $cases[7] = array('civicrm-RC-wordpress.zip', ';/civicrm-(\d|\.|alpha|beta)+-wordpress-?\d*.zip;'); | |||
| $cases[8] = array('civicrm-RC-joomla.zip', ';/civicrm-(\d|\.|alpha|beta)+-joomla-?\d*.zip;'); | |||
| $cases[9] = array('civicrm-RC-backdrop.tar.gz', ';/civicrm-(\d|\.|alpha|beta)+-backdrop-\d*.tar.gz;'); | |||
| $cases[10] = array('civicrm-RC-joomla5.zip', ';/civicrm-(\d|\.|alpha|beta)+-joomla5-?\d*.zip;'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @totten @aydun
I can see that jobs are pushing the J5 version https://test.civicrm.org/job/CiviCRM-Publish/32156/gcsObjects/ but it seems that the web interface doesn't support it yet.