-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the distmaker scripts #31325
base: master
Are you sure you want to change the base?
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
See also #31331 |
Change internal variables names to remove '5' as references to php5
Fix up report Use Joomla5bc instead of Joomla5
Appreciate this work @aydun ! Code looks good to me. Adding The other test fails look like flakes, have hit retry on them. I would think it could be merge-on-pass. |
Thanks @ufundo. |
Overview
Clean up the distmaker scripts. Remove references to 'php5' which are confusing and obsolete.
Renames the newish joomla5 build to 'civicrm-$version-joomla5bc.zip' to denote this requires the Back Compatibility plugin, and clears the way to use '...joomla5.zip' as the native version not requiring BC.
Before
Script names like
backdrop_php5.sh
- but not related to php5.Variables like
D5PACK
- meaning "build the php5 package of drupal"After
Script names like
backdrop.sh
More reasonable variable names.
Technical Details
Should be no difference in the resulting packages.