Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-university-for-the-creative-arts.csl #7153

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ibadger
Copy link
Contributor

@ibadger ibadger commented Aug 6, 2024

Add variable Director, previously had used only Author but this wasn't displaying the Director in references produced in Zotero. If there is a better way to do it do let me know

Add variable Director, previously had used only Author but this wasn't displaying the Director in references produced in Zotero. If there is a better way to do it do let me know
Copy link

github-actions bot commented Aug 6, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Aug 6, 2024

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

harvard-university-for-the-creative-arts.csl (modified style; unchanged output for sample items)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example (2012) At: http://editor.citationstyles.org/searchByExample/ (Accessed 15/12/2012).
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M. and Clark, T. (2019) 'A data citation roadmap for scholarly data repositories' In: Scientific Data 6 (1) p.28. At: http://www.nature.com/articles/s41597-019-0031-8 (Accessed 27/04/2019).
Hancké, B., Rhodes, M. and Thatcher, M. (eds.) (2007) Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. (2001) 'Firms and the welfare state: When, why, and how does social policy matter to employers?' In: Hall, P. A. and Soskice, D. (eds.) Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press. pp.184–213.

Copy link
Member

@bwiernik bwiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated to use a more robust approach.

harvard-university-for-the-creative-arts.csl Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 7, 2024

😟 There are some issues with your submission.

1 test failed

harvard-university-for-the-creative-arts: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [20, "20:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

Please check the test report for details.

Sorry for the delay I've been on leave from work, also I am not much of a coder. Was it missing a Macro for a director? I have added one, any advice is welcome
Copy link

😟 There are some issues with your submission.

1 test failed

harvard-university-for-the-creative-arts: may not have any unused macros

expected: []
     got: ["director"]

(compared using ==)

Please check the test report for details.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

harvard-university-for-the-creative-arts.csl (modified style; unchanged output for sample items)
(Hancké et al., 2007; CSL search by example, 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example (2012) At: http://editor.citationstyles.org/searchByExample/ (Accessed 15/12/2012).
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M. and Clark, T. (2019) 'A data citation roadmap for scholarly data repositories' In: Scientific Data 6 (1) p.28. At: http://www.nature.com/articles/s41597-019-0031-8 (Accessed 27/04/2019).
Hancké, B., Rhodes, M. and Thatcher, M. (eds.) (2007) Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, I. (2001) 'Firms and the welfare state: When, why, and how does social policy matter to employers?' In: Hall, P. A. and Soskice, D. (eds.) Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press. pp.184–213.

@ibadger
Copy link
Contributor Author

ibadger commented Aug 20, 2024

I added a Macro for Director and resubmitted, it seemed to validate but am unsure if it is the best way to go about it. Sorry for the delay I have been away from work, and am a bit slow when it comes to coding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants