Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ieee.csl to incl. video directors | add standard type #6983

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented Mar 27, 2024

https://forums.zotero.org/discussion/113145/ieee-online-video-e-g-youtube#latest

I feel like we should include some other names as well. Any suggestions which?


Also adds the "standard" type to style:
image

image
Requested here: https://forums.zotero.org/discussion/115455/zotero-not-compliant-with-the-ieee-style-guide/p1

Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😟 There are some issues with your submission.

1 test failed

ieee: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[48, "48:0: ERROR: Type dateTime doesn't allow value '2024-03-2719:39:58+00:00'"], [48, "48:0: ERROR...ERROR: Invalid sequence in interleave"], [3, "3:0: ERROR: Element info failed to validate content"]].empty?` to be truthy, got false

Please check the test report for details.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor. Accessed: Dec. 15, 2012. [Online]. Available: http://editor.citationstyles.org/searchByExample/
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds., New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

@zepinglee
Copy link
Contributor

I've collected all the sample entries of the IEEE manual into Zotero format (via https://anystyle.io/) and they may help testing CSL styles: https://gist.github.com/zepinglee/f35d04cbbc240ad0de21de79818761cf.

Fixes this request
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor. Accessed: Dec. 15, 2012. [Online]. Available: http://editor.citationstyles.org/searchByExample/
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds., New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

@POBrien333 POBrien333 changed the title Update ieee.csl to include video directors Update ieee.csl to incl. video directors | add standard type Jul 12, 2024
@bwiernik
Copy link
Member

@POBrien333 Should we go ahead and merge this now and can add more in a future PR?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jul 15, 2024
@POBrien333
Copy link
Contributor Author

Yeah, I'd say so. Let's get that out to the users. :)

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jul 15, 2024
Copy link

😟 There are some issues with your submission.

1 test failed

ieee: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[51, "51:0: ERROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

@POBrien333
Copy link
Contributor Author

Is the type "preprint" not a valid item type (yet)?

@bwiernik
Copy link
Member

Preprint is type "article"

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jul 15, 2024
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor. Accessed: Dec. 15, 2012. [Online]. Available: http://editor.citationstyles.org/searchByExample/
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds., New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor. Accessed: Dec. 15, 2012. [Online]. Available: http://editor.citationstyles.org/searchByExample/
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds., New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

@bwiernik bwiernik merged commit fd6cb3e into citation-style-language:master Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants