fix(plugin-bibtex): fix numeric id in bibtex label

citation-js · Nov 29, 2021 · 6291843 · 6291843
1 parent 6490200
commit 6291843
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/packages/plugin-bibtex/src/mapping/shared.js b/packages/plugin-bibtex/src/mapping/shared.js
@@ -276,7 +276,14 @@ export const Converters = {
       return [label, label]
     },
     toSource (id, label, author, issued, suffix, title) {
-      const safeId = (id && id.replace(unsafeChars, '')) || 'undefined'
+      let safeId
+      if (id === null) {
+        safeId = 'null'
+      } else if (id === undefined) {
+        safeId = 'undefined'
+      } else {
+        safeId = id.toString().replace(unsafeChars, '')
+      }
       if (config.format.useIdAsLabel) {
         return safeId
       }

diff --git a/packages/plugin-bibtex/test/output.json b/packages/plugin-bibtex/test/output.json
@@ -68,7 +68,11 @@
     "label": [[
       {"id": "b", "citation-label": "foo", "type": "book"},
       {"id": "b", "author": [{"given": "foo"}], "type": "book"},
-      {"id": "b", "type": "book"}
+      {"id": "b", "type": "book"},
+      {"id": 123, "type": "book"},
+      {"id": 0, "type": "book"},
+      {"type": "book"},
+      {"id": null, "type": "book"}
     ]],
     "safe labels": [[
       {

diff --git a/packages/plugin-bibtex/test/output/label.bib b/packages/plugin-bibtex/test/output/label.bib
@@ -5,3 +5,11 @@ @book{b
 }
 @book{b,
 }
+@book{123,
+}
+@book{0,
+}
+@book{undefined,
+}
+@book{null,
+}