Add Pill, DeletablePill, EasyPill #81
Conversation
| Pill, | ||
| DeletablePill, | ||
| EasyPill, | ||
| // IMPORT_INJECTOR |
There was a problem hiding this comment.
Missed this in my rebase! Needs to be there for hygen to work it's magic
| * Use EasyComponent moving forward. | ||
| */ | ||
| export const SimpleTabMenu = ({ tabs, activeTab, size = 'sm', ...props }) => { | ||
| export const EasyTabMenu = ({ tabs, activeTab, size = 'sm', ...props }) => { |
There was a problem hiding this comment.
I changed the primary exported component to be EasyTabMenu so it'll be easier to rip out the old one.
Sorry for stepping on your toes, @chelshaw! I wrote most of this last night on the Pill branch when adding EasyPill, for consistency. Just renamed stuff.
There was a problem hiding this comment.
I thought... i already did this in the previously merged code? but good call on switching the default
pixelbandito
force-pushed
the
add-pill-and-variants
branch
from
e71a4dc
to
7818fc5
Compare
| /* colors from zeplin styleguide, created by Egle */ | ||
| /* stylelint-disable comment-empty-line-before */ | ||
|
|
||
| /* --teal: #00837e; */ |
There was a problem hiding this comment.
This is from @andrewBalekha's initial pill commit, which I rebased with my changes.
I know we need to re-map the main color variables so we're not hosting both pre and post-rebranding colors.
But, since I don't have the mapping handy, I thought I'd leave the data in here until next time.
| @@ -0,0 +1,6 @@ | |||
| # DeletablePill | |||
|
|
|||
| When checked, clicking anywhere on a deletable pill fires an `onDelete` function. | |||
There was a problem hiding this comment.
Not sure the deletable pill should always assume clicking on it deletes it. Especially if there's also the clear icon. Also, i find naming the x icon "clear" is sooooo confusing... i thought it was just a blank space like we have in tk-ui for the longest time
pixelbandito
force-pushed
the
add-pill-and-variants
branch
from
8bb4235
to
a16bf08
Compare
I picked up @andrewBalekha's changes from a couple of weeks ago, and split the
Pillso there's a very un-opinionated version in addition to one with a built-in delete action.I also started to stub out an
EasyPill, but it's not ready for use - the actions and callbacks work, but they need to be put into a dropdown, which doesn't exist in RoverUI yet.