Chore: Deprecate Node 10.x support #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelbandito
requested review from
bkonuwa,
dkordik,
lihnick and
wendigolabs
and removed request for
dkordik
pixelbandito
commented
Aug 24, 2021
| @@ -5,22 +5,19 @@ unless_exists: true | |||
| <% PascalName = h.changeCase.pascal(name) %> | |||
| import React from 'react'; | |||
| import classNames from 'classnames'; | |||
| import { ClassValue } from 'classnames/types'; | |||
There was a problem hiding this comment.
🙄 This is something like the 3rd branch in which I've pushed this change. Hopefully this is the first one to merge to master.
pixelbandito
commented
Aug 24, 2021
| @@ -15,7 +15,7 @@ | |||
| "module": "dist/index.module.js", | |||
| "jsnext:main": "dist/index.es.js", | |||
| "engines": { | |||
| "node": ">=10" | |||
There was a problem hiding this comment.
The big thing! node 10 isn't even in maintenance LTS anymore.
https://nodejs.org/en/about/releases/
pixelbandito
commented
Aug 24, 2021
| const [value, setValue] = useState<string | string[] | number | undefined>( | ||
| defaultValue | ||
| ); | ||
| const [value, setValue] = useState<InputValue>(defaultValue); |
There was a problem hiding this comment.
Was throwing a type error because defaultValue was being seen as readonly when it wasn't explicitly typed.
There was a problem hiding this comment.
That's funny, I was running into typing issues on Form, related to various typed inputs, and I think my hack to get it to pass was no bueno. I'll try to steal this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will semantically require a major version, since dropping support for Node 10.x is a breaking change.
However, an internal poll of known consumers indicates no one is using Node 10, and it's no longer a long-term support (LTS) version; so the impact should be minimal to non-existent.