Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Button tag property type to accept strings #330

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix: Update Button tag property type to accept strings #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ interface BaseButtonProps {
hollow?: boolean;
level?: TButtonLevel;
size?: TButtonSize;
tag?: React.FC<TagType> | React.ComponentType<TagType> | null;
tag?: React.FC<TagType> | React.ComponentType<TagType> | string | null;

// States
hover?: boolean;
Expand Down
17 changes: 15 additions & 2 deletions src/components/Button/story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ storiesOf('Planets/Button', module)
marginBottom: '10px',
}}
>
<Button href="#">a</Button>
<Button href="#" tag="a">
a
</Button>
</span>
<span
style={{
Expand All @@ -99,7 +101,18 @@ storiesOf('Planets/Button', module)
marginBottom: '10px',
}}
>
<Button>button (default)</Button>
<Button tag="button" type="button">
button (default)
</Button>
</span>
<span
style={{
display: 'inline-block',
marginRight: '20px',
marginBottom: '10px',
}}
>
<Button tag="input" type="button" value="input type=button" />
</span>
</div>
<h2>Custom type</h2>
Expand Down