feat: EVER-13206: a11y focus states for buttons and links #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelbandito
requested review from
mdespuits,
bkonuwa,
dkordik,
nvmusoke and
wendigolabs
dkordik
approved these changes
May 24, 2021
dkordik
reviewed
May 24, 2021
src/components/Button/story.tsx
Outdated
| [state]: true, | ||
| }), | ||
| {} | ||
| ); |
There was a problem hiding this comment.
another way to do this might be something like this:
const trueStates = Object.fromEntries(
stateCombo.map((state) => [state, true])
);not sure why, but I always need to stare at .reduce's for a while to grok them. but your way feels very React-y
There was a problem hiding this comment.
You're right, it's really hard to read. I'll take a crack at refactoring. I didn't even know about fromEntries, I have a feeling we're going to be friends.
bkonuwa
approved these changes
May 25, 2021
pixelbandito
added a commit
that referenced
this pull request
Aug 20, 2021
* feat: EVER-13206: a11y focus states for buttons and links * test: EVER-13206 Add test for outline class name, restore test for primary level class name * refactor: EVER-13206 Remove todo comment * refactor: EVER-13206: Clean up story truthy prop maker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.