Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts conversion in one fell swoop--hopefully #243

Merged
merged 5 commits into from
Jul 27, 2020
Merged

ts conversion in one fell swoop--hopefully #243

merged 5 commits into from
Jul 27, 2020

Conversation

droddy
Copy link
Contributor

@droddy droddy commented Jul 24, 2020

No description provided.

@droddy droddy mentioned this pull request Jul 24, 2020
Closed
@droddy droddy self-assigned this Jul 24, 2020
@droddy droddy linked an issue Jul 24, 2020 that may be closed by this pull request
Convert Accordion to TypeScript #191
Closed
@droddy droddy changed the title ts conversion in one fell swoop--hopefully WIP - ts conversion in one fell swoop--hopefully Jul 24, 2020
pixelbandito
pixelbandito suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@pixelbandito pixelbandito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just little stuff. 😄

src/components/Accordion/Accordion.tsx Outdated Show resolved Hide resolved
src/components/Accordion/Accordion.tsx Outdated Show resolved Hide resolved
@droddy droddy marked this pull request as draft July 27, 2020 12:48
@droddy droddy requested a review from pixelbandito July 27, 2020 13:58
pixelbandito
pixelbandito approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@pixelbandito pixelbandito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@droddy droddy changed the title WIP - ts conversion in one fell swoop--hopefully ts conversion in one fell swoop--hopefully Jul 27, 2020
@droddy droddy marked this pull request as ready for review July 27, 2020 15:29
@droddy droddy merged commit 77e29ac into master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelbandito pixelbandito pixelbandito approved these changes

@dkordik dkordik Awaiting requested review from dkordik

@sebastianvera sebastianvera Awaiting requested review from sebastianvera

Assignees

@droddy droddy

Labels
typescript conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Accordion to TypeScript
2 participants
@droddy @pixelbandito