Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Input component wrapper. #204

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Add basic Input component wrapper. #204

merged 2 commits into from
Jun 1, 2020

Conversation

pixelbandito
Copy link
Contributor

@pixelbandito pixelbandito commented Jun 1, 2020

I'll need to do this separately against master (v2 beta)

Fixes #202

@mdespuits mdespuits changed the title Add basic Input component wrapper. Fixes #202 Add basic Input component wrapper. Jun 1, 2020
Copy link
Contributor

@mdespuits mdespuits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to change the version to bump the minor version and not both minor and patch. Otherwise looks great!

package.json Outdated Show resolved Hide resolved
@pixelbandito pixelbandito merged commit 4bd0a01 into v1.x Jun 1, 2020
@pixelbandito pixelbandito deleted the add-base-input branch June 1, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants