Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce specificity of checked Pill selector, and... #122

Merged

Conversation

pixelbandito
Copy link
Contributor

@pixelbandito pixelbandito commented Oct 21, 2019

  • Made the Addon's size prop optional (fixes a proptypes error in a test).
  • Made Button display: inline-flex initially. Before doing this I looked for usages in the consuming Cision front-end app, only found one, and manually checked that the style changes didn't break anything in Chrome with dev tools.

Copy link
Contributor

@chelshaw chelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure you run tests before merging 👍

… inline-flex by default to improve initial behavior of Addons.
@pixelbandito pixelbandito force-pushed the bugfix/reduce-specificity-of-checked-pill-selector branch from 9aef563 to 3bb0229 Compare October 21, 2019 17:39
@pixelbandito pixelbandito merged commit 1f7752d into master Oct 21, 2019
@pixelbandito pixelbandito deleted the bugfix/reduce-specificity-of-checked-pill-selector branch October 21, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants