feat+refactor: simplify schema and code api #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintaining versions for different schemas and codes complicates system logic. Now only one copy of schema and code is maintained for a given design. Every time schema update api call is made, a revision number gets incremented. So does the code. Currently, there is no check on whether contents are actually changed. Since schema and code don't need version information anymore, the version information got removed from job specification. Instead, revision numbers are introduced so that user can know whether the schema and code in job is those in the schema and code database by comparing revision numbers between job and schema/code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maintaining versions for different schemas and codes complicates system logic. Now only one copy of schema and code is maintained for a given design. Every time schema update api call is made, a revision number gets incremented. So does the code. Currently, there is no check on whether contents are actually changed.
Since schema and code don't need version information anymore, the version information got removed from job specification. Instead, revision numbers are introduced so that user can know whether the schema and code in job is those in the schema and code database by comparing revision numbers between job and schema/code.
Type of Change
Checklist