Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flamectl job update #447

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

myungjin
Copy link
Contributor

@myungjin myungjin commented Sep 6, 2023

Description

flamectl's job udpate code was not updated when modelSpec and dataSpec were introduced. Therefore, the job update code produces incorrect configuraiton. This bug is now fixed in flamectl code.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

flamectl's job udpate code was not updated when modelSpec and dataSpec
were introduced. Therefore, the job update code produces incorrect
configuraiton. This bug is now fixed in flamectl code.
@codecov-commenter
Copy link

Codecov Report

Merging #447 (142ae9a) into main (d392443) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   14.82%   14.82%           
=======================================
  Files          48       48           
  Lines        2827     2827           
=======================================
  Hits          419      419           
  Misses       2379     2379           
  Partials       29       29           

@myungjin myungjin merged commit 5dc1d46 into cisco-open:main Sep 6, 2023
3 checks passed
@myungjin myungjin deleted the flamectl_job_update branch September 6, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants