refactor: weight_decay moved to config.hyperparameters section #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 14.87% 14.87%
=======================================
Files 48 48
Lines 2830 2830
=======================================
Hits 421 421
Misses 2380 2380
Partials 29 29 |
jaemin-shin
reviewed
Jun 8, 2023
lib/python/flame/optimizer/feddyn.py
Outdated
| @@ -21,7 +21,7 @@ | |||
| from flame.common.constants import TrainState | |||
| from diskcache import Cache | |||
| from ..common.typing import ModelWeights | |||
There was a problem hiding this comment.
Suggested change
| from ..common.typing import ModelWeights | |
| from flame.common.typing import ModelWeights |
lib/python/flame/optimizer/feddyn.py
Outdated
| @@ -21,7 +21,7 @@ | |||
| from flame.common.constants import TrainState | |||
| from diskcache import Cache | |||
| from ..common.typing import ModelWeights | |||
| from ..common.util import (MLFramework, get_ml_framework_in_use) | |||
| from ..common.util import MLFramework, get_ml_framework_in_use | |||
There was a problem hiding this comment.
Suggested change
| from ..common.util import MLFramework, get_ml_framework_in_use | |
| from flame.common.util import MLFramework, get_ml_framework_in_use |
weight_decay was previously used as a parameter for the FedDyn algorithm. However, since it is a common parameter for neural networks, it will be included in the config's hyperparameters section (optional to specify). This parameter has been removed from the FedDyn optimizer and FedDyn regularizer as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
weight_decay was previously used as a parameter for the FedDyn algorithm. However, since it is a common parameter for neural networks, it will be included in the config's hyperparameters section (optional to specify).
This parameter has been removed from the FedDyn optimizer and FedDyn regularizer as well.
Type of Change
Checklist