fix: incorrect task status update by deployer #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After deployer uninstall pods, it doesn't stop monitoring. Thus, the deployer thinks that pods' status is unknown and updates tasks' status as fail. This bug is fixed.
myungjin
force-pushed
the
harden_deployer_monitor
branch
from
4039aca
to
4ffe9e7
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 14.87% 14.87%
=======================================
Files 48 48
Lines 2830 2830
=======================================
Hits 421 421
Misses 2380 2380
Partials 29 29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After deployer uninstall pods, it doesn't stop monitoring. Thus, the deployer thinks that pods' status is unknown and updates tasks' status as fail. This bug is fixed.
Type of Change
Checklist