Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add debug message in deployer #428

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

myungjin
Copy link
Contributor

@myungjin myungjin commented Jun 2, 2023

Description

To aid debugging in deployer, add a debugging message.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

jaemin-shin
jaemin-shin previously approved these changes Jun 2, 2023
Copy link
Collaborator

@jaemin-shin jaemin-shin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #428 (407cbe7) into main (d697f2c) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   14.86%   14.87%   +0.01%     
==========================================
  Files          48       48              
  Lines        2832     2830       -2     
==========================================
  Hits          421      421              
+ Misses       2382     2380       -2     
  Partials       29       29              
Impacted Files Coverage Δ
cmd/controller/app/job/builder.go 70.16% <ø> (+0.45%) ⬆️

To aid debugging in deployer, add a debugging message.
Copy link
Collaborator

@jaemin-shin jaemin-shin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@myungjin myungjin merged commit 675439f into cisco-open:main Jun 2, 2023
@myungjin myungjin deleted the deployer_debug branch June 2, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants